From d38b57faafe20c4cd3c804b23027a1e61076b9aa Mon Sep 17 00:00:00 2001
From: uncor3 <contactuncor3@gmail.com>
Date: Fri, 14 Nov 2025 05:16:16 +0000
Subject: [PATCH] fix macos build

---
 .github/workflows/build-macos.yml | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/build-macos.yml b/.github/workflows/build-macos.yml
index b527c0d..0d91690 100644
--- a/.github/workflows/build-macos.yml
+++ b/.github/workflows/build-macos.yml
@@ -36,10 +36,6 @@ jobs:
           version: ${{ env.QT_VERSION }}
           modules: "qtmultimedia qtlocation qtpositioning qtserialport"
 
-      - uses: actions/setup-node@v6
-        with:
-          node-version: 24
-
       - name: Update pkgconfig path
         run: |
           echo "PKG_CONFIG_PATH=$(brew --prefix)/lib/pkgconfig:${PKG_CONFIG_PATH:-}" >> "$GITHUB_ENV"
@@ -71,8 +67,7 @@ jobs:
             gst-plugins-bad \
             gst-plugins-ugly \
             gst-libav \
-            graphicsmagick \
-            imagemagick
+            create-dmg
 
       - name: Compile additional dependencies
         run: |
@@ -181,8 +176,17 @@ jobs:
 
       - name: Create DMG
         run: |
-          npm install -g create-dmg
-          create-dmg --volname "iDescriptor" --window-size 500 300 --icon-size 100 --app-drop-link 400 150 --icon "iDescriptor.app" 100 150 "build/iDescriptor.dmg" "build/iDescriptor.app" --no-code-sign
+          create-dmg \
+            --volname "iDescriptor" \
+            --volicon "resources/icons/app-icon/icon.icns" \
+            --window-pos 200 120 \
+            --window-size 600 400 \
+            --icon-size 100 \
+            --icon "iDescriptor.app" 175 190 \
+            --hide-extension "iDescriptor.app" \
+            --app-drop-link 425 190 \
+            "build/iDescriptor-macOS-${{ matrix.arch }}.dmg" \
+            "build/iDescriptor.app"
 
       - name: Upload Artifact
         uses: actions/upload-artifact@v4